Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize glob matching logic #296

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Optimize glob matching logic #296

merged 7 commits into from
Apr 23, 2024

Conversation

PaulusParssinen
Copy link
Contributor

@PaulusParssinen PaulusParssinen commented Apr 20, 2024 •
edited
Loading

Make the GlobUtils.Match do direct ASCII comparisons instead of more expensive culture-sensitive ones.

Sample diff of one of the conditions before and after:
image

lmaas
lmaas approved these changes Apr 22, 2024
View reviewed changes
libs/server/GlobUtils.cs Outdated Show resolved Hide resolved
lmaas
lmaas suggested changes Apr 22, 2024
View reviewed changes
libs/server/GlobUtils.cs Outdated Show resolved Hide resolved
@lmaas lmaas self-assigned this Apr 23, 2024
lmaas
lmaas approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@lmaas lmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Let's merge this in. Thanks for your contribution! 🙌

@lmaas lmaas merged commit 4d37ca7 into microsoft:main Apr 23, 2024
21 checks passed
@PaulusParssinen PaulusParssinen deleted the glob-utils-minor-optimization branch April 23, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badrishc badrishc badrishc approved these changes

@lmaas lmaas lmaas approved these changes

Assignees

@lmaas lmaas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulusParssinen @lmaas @badrishc