Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache stateless comparers #340

Merged
merged 4 commits into from
May 1, 2024
Merged

Cache stateless comparers #340

merged 4 commits into from
May 1, 2024

Conversation

PaulusParssinen
Copy link
Contributor

@PaulusParssinen PaulusParssinen commented Apr 27, 2024 •
edited
Loading

This PR optimizes the usage of stateless ITsavoriteEqualityComparer and other comparer implementations.

Commits

@PaulusParssinen
Use ldtoken + castclass instead of ldtoken + isinst in TsavoriteEqual…
7513642 
…ityComparer.Get

* JIT is more "used" to former pattern.
@PaulusParssinen
Cache key comparers in Tsavorite
f422150
@PaulusParssinen
Cache stateless comparers in Garnet
a1ec942 
* i.e.ByteArrayComparer and SortedSetComparer
@TalZaccai TalZaccai requested a review from TedHartMS April 30, 2024 22:37
@badrishc badrishc merged commit 918775d into microsoft:main May 1, 2024
30 checks passed
@PaulusParssinen PaulusParssinen deleted the cache-comparers branch May 2, 2024 03:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tornhoof Tornhoof Tornhoof left review comments

@TedHartMS TedHartMS TedHartMS approved these changes

@badrishc badrishc badrishc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulusParssinen @Tornhoof @TedHartMS @badrishc