Clear input header field (flags) for object store RMW operations #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set the flag field to 0 as the buffer being used to create the input may not be zero'ed out.
TedHartMS
approved these changes
May 3, 2024
PaulusParssinen
pushed a commit
to PaulusParssinen/garnet
that referenced
this pull request
May 7, 2024
…rosoft#357) * When preparing input for the object store RMW operations, we need to set the flag field to 0 as the buffer being used to create the input may not be zero'ed out. * small fix * Clean up Unit Test --------- Co-authored-by: TedHartMS <15467143+TedHartMS@users.noreply.github.com>
PaulusParssinen
pushed a commit
to PaulusParssinen/garnet
that referenced
this pull request
May 8, 2024
…rosoft#357) * When preparing input for the object store RMW operations, we need to set the flag field to 0 as the buffer being used to create the input may not be zero'ed out. * small fix * Clean up Unit Test --------- Co-authored-by: TedHartMS <15467143+TedHartMS@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing input for the object store RMW operations, we need to set the flag field to 0, as the buffer being used to create the input may not be zero'ed out.
Fixes #342