Enforce object store total memory size constraint during recovery #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrajas
force-pushed
the
yrajas/objectstorerecovery
branch
from
66a4cb5
to
dd22fd0
Compare
added 6 commits
May 9, 2024 21:01
yrajas
force-pushed
the
yrajas/objectstorerecovery
branch
from
e48ea03
to
71eb38a
Compare
TedHartMS
approved these changes
May 23, 2024
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
…crosoft#359) * Initial commit. * Track object store size changes when pages get evicted. * Start resize task after completing recovery. Fix head address post recovery. * Fixes and code cleanup. * Avoid interface usage. * Free pages after read completion. * Formatting fixes. * Resolved PR comments. --------- Co-authored-by: Yoganand Rajasekaran <yrajas@ntdev.microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Whenever object store operations are performed, corresponding heap size impact is computed and tracked to ensure that the total memory size is within the user configured limit. However, this constraint is not currently enforced during recovery. This change addresses that.
Fix description
OnDeserializationObserver, that can compute and use theCacheSizeTrackerto track heap usage when pages are read in during recovery.LogOperationObserveris added to perform this.EvictPageone at a time until the total memory size is back within the limit.DoPostRecoveryupdatesheadAddressto account for the freed pages.