Basic implementation of HELLO #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TalZaccai
requested changes
May 18, 2024
TalZaccai
requested changes
May 18, 2024
|
Made this PR have HELLO work only with RESP2, the other open PR will add RESP3 for async. |
|
fixed warnings |
yrajas
reviewed
May 20, 2024
TalZaccai
reviewed
May 20, 2024
TalZaccai
reviewed
May 20, 2024
TalZaccai
requested changes
May 20, 2024
TalZaccai
approved these changes
May 20, 2024
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
* Basic implementation of HELLO command * fix * Added command info for HELLO + added website docs * dotnet format * update SE.Redis to latest, add HELLO unit test * Add and use EqualsIgnoreCase * use nameof(RespCommand.HELLO) * updates * support special pong in RESP2 subscribe * only support RESP2 in this PR * remove resp3 testcase * fix warnings * fix warning * make EqualsIgnoreCase extension method in utils * improve the case-insensitive match test * nit --------- Co-authored-by: Tal Zaccai <talzacc@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #387
Fixes #346
Fixes #179