Support WITHSCORE option in ZRANK, ZREVRANK commands #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrishc
approved these changes
May 29, 2024
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
* Draft changes. * Support WITHSCORE in ZRANK, ZREVRANK. --------- Co-authored-by: Yoganand Rajasekaran <yrajas@ntdev.microsoft.com> Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, processing accepts the WITHSCORE parameter to ZRANK and ZREVRANK commands, but the result is not built with the score if the parameter is passed in.
Fix
Modified the ZRANK, ZREVRANK implementation to have the ability to provide either a single rank integer output or an array output based on presence of WITHSCORE parameter.