Add flag for backward compatibility with TLS checks #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag should be enabled by default, and gossip should set this flag as well so that the gossip client validates the certificate. |
vazois
reviewed
May 29, 2024
vazois
approved these changes
May 29, 2024
chyin6
pushed a commit
to jusjin-org/garnet
that referenced
this pull request
Jul 2, 2024
* change option name * update flag name * remove braces * nit; fix breaking TestUtils initialization for TLS options * cleanup of PR * minor rephrasing --------- Co-authored-by: Vasileios Zois <vazois@microsoft.com> Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #392, we added stronger TLS checks for cluster gossip to prevent an unintended node from connecting. The behavior might be unexpected for some of consumers (using older versions of Garnet) as this would mean specifying the ClusterTlsClientTargetHost parameter which they might've missed earlier as it was not validated in all scenarios - it was behind a ClientCertificateRequired flag. This flag also implied that server cert was also not validated when Garnet acted as a client in gossip scenarios.
But to maintain backward compatibility we're adding another flag to enable the stronger TLS checks conditionally. However, it should be recommended that this is turned on to prevent unexpected cluster connections.