Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add user-friendly methods for INCR/DECR and ZRANK/ZREVRANK #434

Merged
merged 10 commits into from
Jun 12, 2024
Merged

API: Add user-friendly methods for INCR/DECR and ZRANK/ZREVRANK #434

merged 10 commits into from
Jun 12, 2024

Conversation

Mimi8298
Copy link
Contributor

Add new methods to the API to simplify its use:

  • SortedSetRank allows ZRANK/ZREVRANK to be called via key and member
  • Increment allows INCR/DECR/INCRBY/DECRBY to be called via key and increment number. OperationError is returned but I don't know if this is the best way to return it? I've seen that other methods simply return a string as an error

@Mimi8298
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Mimi8298
Copy link
Contributor Author

Is it possible to re-run the action?
Something went wrong at the results upload (github issue)

@TalZaccai TalZaccai self-requested a review June 4, 2024 18:11
TalZaccai
TalZaccai requested changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for changes, any updates? :)

libs/server/Storage/Session/MainStore/MainStoreOps.cs Outdated Show resolved Hide resolved
libs/server/API/IGarnetApi.cs Outdated Show resolved Hide resolved
libs/server/Storage/Session/ObjectStore/SortedSetOps.cs Show resolved Hide resolved
libs/server/Storage/Session/MainStore/MainStoreOps.cs Outdated Show resolved Hide resolved
libs/server/Storage/Session/ObjectStore/SortedSetOps.cs Show resolved Hide resolved
@Mimi8298 Mimi8298 requested a review from TalZaccai June 11, 2024 13:13
@TalZaccai TalZaccai merged commit 66ebaa7 into microsoft:main Jun 12, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees

@TalZaccai TalZaccai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mimi8298 @TalZaccai @badrishc