Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some TimeSpan duration code #439

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix some TimeSpan duration code #439

merged 2 commits into from
Jun 4, 2024

Conversation

kevin-montrose
Copy link
Contributor

Noticed while working on ACLs, these uses of TimeSpan.Seconds and TimeSpan.Days appear incorrect.

Switched to using the TimeSpan.TotalXXX equivalents which return total duration in whatever unit, not just the "component" bit of the TimeSpan.

@kevin-montrose
fix couple places where incorrect TimeSpan method was used, intent wa…
35f4990 
…s to get duration so we need the TotalXXX properties in these places
vazois
vazois approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@vazois vazois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@badrishc badrishc merged commit 2dff684 into microsoft:main Jun 4, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vazois vazois vazois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin-montrose @vazois @badrishc