Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Kill bufSpan #452

Merged
merged 3 commits into from
Jun 10, 2024
Merged

[Cleanup] Kill bufSpan #452

merged 3 commits into from
Jun 10, 2024

Conversation

badrishc
Copy link
Contributor

@badrishc badrishc commented Jun 7, 2024 •
edited
Loading

Side effect: fixed a bug with how response was sent for a "ping " call

@badrishc
[Cleanup] Kill bufSpan
4905280 
Side effect: fixed a bug with how resposene was sent for a "ping <message>" call
@badrishc
nit
ab1f8ca
@badrishc
add comments for RespCommand boundaries
56b1f6b
@badrishc
Copy link
Contributor Author

badrishc commented Jun 8, 2024

BDN Results

Arguments: -f *.RespParseStress.*

main (abfbff0)

Method Mean Error StdDev Allocated
InlinePing 2.723 us 0.0309 us 0.0289 us -
Set 25.946 us 0.2416 us 0.2260 us -
Get 15.625 us 0.2039 us 0.1702 us -

PR (56b1f6b)

Method Mean Error StdDev Allocated
InlinePing 2.667 us 0.0484 us 0.0453 us -
Set 26.093 us 0.5013 us 0.4923 us -
Get 16.174 us 0.1985 us 0.1658 us -

@badrishc badrishc merged commit 7c9ac99 into main Jun 10, 2024
26 checks passed
@badrishc badrishc deleted the badrishc/kill-bufSpan branch June 10, 2024 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@badrishc