-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Parsing Regression in GarnetClient and GarnetClientSession #456
Merged
vazois
merged 15 commits into
microsoft:main
from
vazois:vazois/fix-garnetclientsession-regression
Jun 12, 2024
Merged
Fix Parsing Regression in GarnetClient and GarnetClientSession #456
vazois
merged 15 commits into
microsoft:main
from
vazois:vazois/fix-garnetclientsession-regression
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badrishc
approved these changes
Jun 10, 2024
lmaas
reviewed
Jun 10, 2024
vazois
force-pushed
the
vazois/fix-garnetclientsession-regression
branch
2 times, most recently
from
June 10, 2024 22:43
765dac3
to
9c52e2c
Compare
vazois
force-pushed
the
vazois/fix-garnetclientsession-regression
branch
from
June 11, 2024 01:59
e31c3f3
to
9a35c7e
Compare
TalZaccai
requested changes
Jun 11, 2024
vazois
force-pushed
the
vazois/fix-garnetclientsession-regression
branch
from
June 11, 2024 23:19
3d7d3b2
to
6022841
Compare
vazois
force-pushed
the
vazois/fix-garnetclientsession-regression
branch
from
June 12, 2024 00:05
6022841
to
d38ccb2
Compare
TalZaccai
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as an attempt to fix the parsing regression introduced in 5202499.
It involved into a general refactoring of RespReadUtils to clearly separate the parts used only by the clients to parse RESP responses vs those used internally by the server.
This distinction is crucial because the server does not access negative length headers (i.e. $-1\r\n) but the client can accept them as part of a response packet.
Following is a summary of the related fixes/enhancements: