Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty collection key deletion - continued #466

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Empty collection key deletion - continued #466

merged 5 commits into from
Jun 17, 2024

Conversation

TalZaccai
Copy link
Contributor

@TalZaccai TalZaccai commented Jun 14, 2024 •
edited
Loading

  • Implemented key deletion for emptied collection when RMW is not called (and underlying object is directly altered)
  • Extended tests to test that keys are being removed for each command that may empty the object collection

(Continues the fixes introduced in PR #443)

@TalZaccai TalZaccai merged commit 34196bc into main Jun 17, 2024
26 checks passed
@TalZaccai TalZaccai deleted the talzacc/empty_collections_cont branch June 17, 2024 21:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@badrishc badrishc badrishc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalZaccai @badrishc