Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary out-of-band NuGet packages from Tsavorite.core #54

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

PaulusParssinen
Copy link
Contributor

@PaulusParssinen PaulusParssinen commented Mar 20, 2024

These package, similarly to the #33, seem left overs from the FASTER implementation which targeted .NET Standard. We don't need the OOB packages such as System.Memory anymore.

Moved System.Interactive.Async reference to the Tsavorite.devices.AzureStorageDevice project which needs it for IAsyncEnumerable<TSource>.FirstAsync extension helper.

It may be worth it to use Director.Build.props to unify various shared .csproj settings into one place.

@badrishc badrishc merged commit b41148f into microsoft:main Mar 20, 2024
10 checks passed
@PaulusParssinen PaulusParssinen deleted the tsavorite-deps branch March 21, 2024 01:25
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants