Added expiration to garnet objects at time of serialization deserialization #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeepyadavmsft
changed the title
badrishc
approved these changes
Mar 20, 2024
pradeepyadavmsft
force-pushed
the
pyadav/expireFix
branch
from
dfbfbaa to
478bdb1
Compare
yrajas
reviewed
Mar 20, 2024
yrajas
approved these changes
Mar 20, 2024
|
The proposed serialization format is: |
yrajas
force-pushed
the
pyadav/expireFix
branch
from
6fa8eeb to
4cb2135
Compare
badrishc
reviewed
Mar 22, 2024
badrishc
reviewed
Mar 22, 2024
yrajas
force-pushed
the
pyadav/expireFix
branch
from
98afd41 to
38ef50b
Compare
…hrough GarnetObject
yrajas
force-pushed
the
pyadav/expireFix
branch
from
38ef50b to
9bc3c53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses a bug where expiration is not being added to serialization, potentially causing some objects to become live again after recovery from a checkpoint.
If you are using the object store, please clean up older checkpoints as it will not be able to deserialize them due to the breaking nature of this change.