Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullReferenceException when outputting CustomObjectCommand error message #60

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

argsno
Copy link
Contributor

@argsno argsno commented Mar 21, 2024

the error message is:

08::34::20 crit: Session[0] [198.18.0.1:3278] [127.0.0.1:58858] [020A9EF0] ProcessMessages threw exception System.NullReferenceException: Object reference not set to an instance of an object.    
at Garnet.server.RespServerSession.ProcessOtherCommands[TGarnetApi](Int32 count, TGarnetApi& storageApi) in /Users/argsno/Projects/garnet/libs/server/Resp/RespServerSession.cs:line 588    
at Garnet.server.RespServerSession.ProcessArrayCommands[TGarnetApi](TGarnetApi& storageApi) in /Users/argsno/Projects/garnet/libs/server/Resp/RespServerSession.cs:line 496    
at Garnet.server.RespServerSession.ProcessBasicCommands[TGarnetApi](Byte* ptr, RespCommand cmd, TGarnetApi& storageApi) in /Users/argsno/Projects/garnet/libs/server/Resp/RespServerSession.cs:line 368    
at Garnet.server.RespServerSession.ProcessMessages() in /Users/argsno/Projects/garnet/libs/server/Resp/RespServerSession.cs:line 273    
at Garnet.server.RespServerSession.TryConsumeMessages(Byte* reqBuffer, Int32 bytesReceived) in /Users/argsno/Projects/garnet/libs/server/Resp/RespServerSession.cs:line 199

@badrishc
Copy link
Contributor

Great find and fix, thanks!

@TalZaccai TalZaccai merged commit 782372f into microsoft:main Mar 21, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants