-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure pre-serialized values are deleted after flush #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
badrishc
commented
Mar 21, 2024
•
edited
Loading
edited
- When we PostCopyUpdate an object, we replace the old image in the log with its serialized representation so that we have a consistent old version of the object. This PR optimizes this case to occur only during a snapshot checkpoint, because the (v) version needs to be captured only in that case.
- The disk flush thread (either snapshot or head page flush) can pick up this serialized data for version (v) to write to disk.
- We currently leave the serialized data intact in memory which causes heap to grow with repeated checkpoints. In this PR, we scan the log after the checkpoint to replace it with a null, in order to save on extra memory use.
- Scan was extended to support scanning sealed records, as the serialized data is attached to the sealed records.
- A subsequent snapshot can write Null to storage for this object, as we know the object is subsumed by a newer version thanks to the PCU.
- Recovering from a checkpoint will reconstitute a null object, which is fine because a newer version of the object is known to exist.
- This means we may now have null objects on the log - this is fine because Scan will always check for new version. We added support for a null object type in the serialized representation.
…t to avoid edge case of it being written null to disk storage
pradeepyadavmsft
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.