Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Added ZDIFFSTORE command #732

Merged
merged 12 commits into from
Oct 28, 2024
Merged

[Compatibility] Added ZDIFFSTORE command #732

merged 12 commits into from
Oct 28, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the ZDIFFSTORE command to garnet

  • Add ZDIFFSTORE command
  • Add Integration Test cases, ACL Test and Slot Verification Test
  • Add documentation

@Vijay-Nirmal
Copy link
Contributor Author

@vazois Can you help fix ClusterSlotVerificationTests issue? I am getting ERR Garnet Exception: FindKeysUnknown range

@TalZaccai TalZaccai self-requested a review October 17, 2024 18:16
@vazois
Copy link
Contributor

vazois commented Oct 18, 2024

@vazois Can you help fix ClusterSlotVerificationTests issue? I am getting ERR Garnet Exception: FindKeysUnknown range

Check PR #734 and let me know if that fixes your issue

TalZaccai
TalZaccai requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added a few comments

libs/server/API/GarnetApiObjectCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespSortedSetTests.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespSortedSetTests.cs Outdated Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Test case failure in the pipeline will be fixed as part of #748

@TalZaccai TalZaccai merged commit 4e3b462 into microsoft:main Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vijay-Nirmal @vazois @TalZaccai