Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for slowlog #971

Merged
merged 38 commits into from
Feb 4, 2025
Merged

Add support for slowlog #971

merged 38 commits into from
Feb 4, 2025

Conversation

badrishc
Copy link
Contributor

@badrishc badrishc commented Jan 29, 2025 •
edited
Loading

  • Added support for SLOWLOG [HELP|GET|LEN|RESET] commands.
  • Support options of SlowLogThreshold and SlowLogMaxEntries.

@badrishc badrishc marked this pull request as ready for review January 29, 2025 20:21
@badrishc badrishc requested a review from TalZaccai January 29, 2025 20:21
@badrishc badrishc changed the title Basic implementation of slowlog Add support for slowlog Jan 29, 2025
TalZaccai
TalZaccai approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, generally looks good to me

libs/host/Configuration/Options.cs Show resolved Hide resolved
libs/host/Configuration/Options.cs Show resolved Hide resolved
libs/server/Metrics/Slowlog/RespSlowlogCommands.cs Outdated Show resolved Hide resolved
libs/server/Metrics/Slowlog/RespSlowlogHelp.cs Show resolved Hide resolved
libs/server/Metrics/Slowlog/RespSlowlogCommands.cs Outdated Show resolved Hide resolved
libs/server/Metrics/Slowlog/SlowLogContainer.cs Outdated Show resolved Hide resolved
libs/server/Metrics/Slowlog/SlowLogContainer.cs Show resolved Hide resolved
@badrishc badrishc merged commit 0ddfc9e into main Feb 4, 2025
15 checks passed
@badrishc badrishc deleted the badrishc/slowlog-v1 branch February 4, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badrishc @TalZaccai