Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PExpire testcase #977

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix PExpire testcase #977

merged 2 commits into from
Jan 30, 2025

Conversation

badrishc
Copy link
Contributor

@badrishc badrishc commented Jan 30, 2025

Fix PExpire testcase

It was failing sporadically due to timing issues as the timeout was too low (15ms).

Example: https://github.com/microsoft/garnet/actions/runs/13042680970/job/36387756667#step:6:2873

  Error Message:
   System.InvalidOperationException : Nullable object must have a value.
  Stack Trace:
     at System.Nullable`1.get_Value()
   at Garnet.test.RespTests.KeyExpireOptionsTest(String command, Boolean testCaseSensitivity) in /_/test/Garnet.test/RespTests.cs:line 2587
   at InvokeStub_RespTests.KeyExpireOptionsTest(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

It was failing sporadically due to timing issues as the timeout was too low (15ms).
@badrishc badrishc merged commit d148f51 into main Jan 30, 2025
19 checks passed
@badrishc badrishc deleted the badrishc/fix-pexpire-testcase branch January 30, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants