Added BDN for all Sorted Set commands #991
Conversation
Triggered here: https://github.com/microsoft/garnet/actions/runs/13105237393 |
|
@badrishc I don't see SortedSetOperations in the benchmark result. Didn't spend time to analyze why but I assumed it because I didn't update BDN_Benchmark_Config.json. Now I have updated, can you retrigger it? |
I thought there was an attachment related to sorted sets, at the bottom of the actions page. |
|
Looks like Badrish has answered your questions. If you have more, let me know. |
There was a problem hiding this comment.
-
in test\BDNPerfTests\run_bdnperftest.ps1 the size of objects you are accessing is more than 70 so change line to $expectedResultsArray = New-Object 'string[,]' 100, 3
-
You will need to update the BDN_Benchmark_Config.json file. You can run BDN manually or run this ps1 which is ran in the BDN pipeline:
.\test\BDNPerfTests> .\run_bdnperftest.ps1 Operations.SortedSetOperations
|
@Vijay-Nirmal From the looks of it, it is ready other than the two changes I requested. |
|
@darrenge Fixed it |
|
Trying it out locally, but I see branch Vijay-Nirmal/BDN/sorted-set does NOT have these changes. The pr/991 branch has today's changes so I was able to get things locally. However, since Vijay-Nirmal... branch is not up to date, I can't actually run the BDN pipeline on it. I tried: git branch --set-upstream-to=origin/Vijay-Nirmal/BDN/sorted-set Vijay-Nirmal/BDN/sorted-set @Vijay-Nirmal - can you get your original branch (Vijay-Nirmal/BDN/sorted-set ) up to date? |
There was a problem hiding this comment.
I ran this locally on my WIndows machine and there were four places where the expected is lower than the actual. If you are testing on a linux machine, then these might differ and you should take the higher value. The ones I saw failed:
ZInter AOF The BDN benchmark found Allocated value (123200) is above the acceptable threshold of 37840 (Expected value 34400 + 10%)
ZUnion AOF The BDN benchmark found Allocated value (129600) is above the acceptable threshold of 37840 (Expected value 34400 + 10%)
ZInter None The BDN benchmark found Allocated value (79200) is above the acceptable threshold of 37840 (Expected value 34400 + 10%)
ZUnion None The BDN benchmark found Allocated value (84800) is above the acceptable threshold of 37840 (Expected value 34400 + 10%)
Vijay-Nirmal/BDN/sorted-set is a mirror i created for the BDN purpose. I have updated it to reflect the latest from Vijay's branch. |
…undaries for exact matches
|
@darrenge Fixed the issue. Issue was with |
… script to improve performance
This pull request introduces a new benchmark for all Sorted Set commands as per #879 (comment).