GCToolkitVertxParameters#createAggregator should not arbitrarily pick the first constructor

[dsgrieve]

Describe the bug
com.microsoft.gctoolkit.vertx.jvm.GCToolkitVertxParameters#createAggregator does this:
return (Aggregator<?>) aggregatorClass.getConstructors()[0].newInstance(aggregationClass.getConstructors()[0].newInstance());
But this could blow up if the class has more than one constructor. Instead, the code should look for the no-arg constructor (for the Aggregation) and the constructor that takes an Aggregation (for the Aggregator).

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[brunoborges]

Any thoughts on doing a builder interface/factory?

For reference: https://github.com/microsoft/gctoolkit/blob/main/vertx/src/main/java/com/microsoft/gctoolkit/vertx/jvm/GCToolkitVertxParameters.java#L83

[kcpeppe]

Fix is easy, filter through the list and look for the zero agr constructor. can you suggest how a builder or factory anti-pattern helps?

…

On Fri, Mar 25, 2022 at 14:15 Bruno Borges ***@***.***> wrote: Any thoughts on doing a builder interface/factory? — Reply to this email directly, view it on GitHub <#214 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2NJ6LYK2ZA3X65L5DEG3VBYUG5ANCNFSM5RVDABBQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[dsgrieve]

#216