[ZGC][parser] Ensure that ZGCMemoryPoolSummary and OccupancySummary use kilobytes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eceive values normalized to kilobytes. The code in its current form will return a double without taking into account the units associated with the memory. This can lead to multiple GC cycles that report odd results. This diff ensures that as they are parsed the are normalized to a long in terms of kilobytes
|
Also, apologies for closing and re-opening this PR, I forgot to commit the test changes. They've been updated in this PR. |
karianna
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that ZGC memory values are normalized to kilobytes. The code in its current form will return a double without taking into account the units associated with the memory value. This can lead to multiple GC cycles that report odd results. This diff ensures that as they are parsed they are normalized to a long value in kilobytes. The regex's already capture the units so we'll simply scale the constructor inputs to ZGCMemoryPoolSummary and OccupancySummary by the captured unit string. We'll use the helper method
.toKBytes(...)which is available to us in the the trace class already.Please let me know if there is a project code formatting standard, I'd be happy to reformat to meet the project standards. While working, the editor cleaned up a number of spacing issues which lead to a slightly larger PR than expected. I wish this could have been picked up in a separate, format only diff. Anyways. Please let me know if I can better address this.