🐛 fix for issue #274 #275
Merged
🐛 fix for issue #274 #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
karianna
approved these changes
Mar 1, 2023
api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java
Outdated
Show resolved
Hide resolved
karianna
requested changes
Mar 1, 2023
|
This PR should be in draft mode. Sorry for not making that so. |
karianna
approved these changes
Mar 2, 2023
karianna
requested changes
Mar 2, 2023
IT/src/test/java/com/microsoft/gctoolkit/integration/CaptureJVMTerminationEventTest.java
Outdated
Show resolved
Hide resolved
IT/src/test/java/com/microsoft/gctoolkit/integration/MissingAnnotationTest.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/microsoft/gctoolkit/jvm/AbstractJavaVirtualMachine.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/com/microsoft/gctoolkit/parser/unittests/UnifiedGenerationalParserTest.java
Outdated
Show resolved
Hide resolved
…MTerminationEventTest.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
…notationTest.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
DateTimeStamp implements Comparable<DateTimeStamp> so delegate before and after methods to the compareTo method
karianna
approved these changes
Mar 2, 2023
dsgrieve
approved these changes
Mar 2, 2023
| DateTimeStamp smaller = new DateTimeStamp(123); | ||
| DateTimeStamp greater = new DateTimeStamp(124); | ||
| assertEquals(-1, smaller.compareTo(greater)); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I think you should leave this test in, especially since the compareTo implementation hasn't changed (it should still throw an IllegalStateException). This will help flag possible changes in behavior down the road.
| @@ -6,7 +6,7 @@ | |||
| <parent> | |||
| <groupId>com.microsoft.gctoolkit</groupId> | |||
| <artifactId>gctoolkit</artifactId> | |||
| <version>3.0.3-SNAPSHOT</version> | |||
parser/pom.xml
Outdated
| @@ -5,7 +5,7 @@ | |||
| <parent> | |||
| <groupId>com.microsoft.gctoolkit</groupId> | |||
| <artifactId>gctoolkit</artifactId> | |||
| <version>3.0.3-SNAPSHOT</version> | |||
| <version>3.0.3</version> | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use case for DateTimeStamp without the time stamp has been added to support logs that don't have a time stamp set. The fix is to convert the date stamp to seconds from epoch.