This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
vscode: Parse settings with comments #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If needed developer can revert the removed comments at the cost of loosing JSON compliance. The alternative would be to use an other non standard JSON.parse Bug: microsoft#104 Forwarded: microsoft#146 Change-Id: I80f8b290b846f62abaf5b99d424a8cfdfd9f84a1 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
|
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
eeb3359
to
c4f1e58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If needed developer can revert the removed comments
at the cost of loosing JSON compliance.
Bug: #104
Forwarded: https://github.com/Microsoft/generator-docker/pulls
Change-Id: I80f8b290b846f62abaf5b99d424a8cfdfd9f84a1
Signed-off-by: Philippe Coval p.coval@samsung.com