Skip to content

Commit

Permalink
gvfs-helper: dramatically reduce progress noise
Browse files Browse the repository at this point in the history
During development, it was very helpful to see the gvfs-helper do its
work to request a pack-file or download a loose object. When these
messages appear during normal use, it leads to a very noisy terminal
output.

Remove all progress indicators when downloading loose objects. We know
that these can be numbered in the thousands in certain kinds of history
calls, and would litter the terminal output with noise. This happens
during 'git fetch' or 'git pull' as well when the tip commits are
checked for the new refs.

Remove the "Requesting packfile with %ld objects" message, as this
operation is very fast. We quickly follow up with the more valuable
"Receiving packfile %ld%ld with %ld objects". When a large "git
checkout" causes many pack-file downloads, it is good to know that Git
is asking for data from the server.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
  • Loading branch information
derrickstolee authored and dscho committed Aug 16, 2023
1 parent 1072daf commit 052677c
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions gvfs-helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -2571,17 +2571,11 @@ static void setup_gvfs_objects_progress(struct gh__request_params *params,
return;

if (params->b_is_post && params->object_count > 1) {
strbuf_addf(&params->progress_base_phase2_msg,
"Requesting packfile %ld/%ld with %ld objects",
num, den, params->object_count);
strbuf_addf(&params->progress_base_phase3_msg,
"Receiving packfile %ld/%ld with %ld objects",
num, den, params->object_count);
} else {
strbuf_addf(&params->progress_base_phase3_msg,
"Receiving %ld/%ld loose object",
num, den);
}
/* If requesting only one object, then do not show progress */
}

/*
Expand Down

0 comments on commit 052677c

Please sign in to comment.