Skip to content

Commit

Permalink
config.c: pass ctx with CLI config
Browse files Browse the repository at this point in the history 
Pass config_context when parsing CLI config. To provide the .kvi member,
refactor out kvi_from_param() from the logic that caches CLI config in
configsets. Now that config_context and config_context.kvi is always
present when config machinery calls config callbacks, plumb "kvi" so
that we can remove all calls of current_config_scope() except for
trace2/*.c (which will be handled in a later commit), and remove all
other current_config_*() (the functions themselves and their calls).
Note that this results in .kvi containing a different, more complete
set of information than the mocked up "struct config_source" in
git_config_from_parameters().

Plumbing "kvi" reveals a few places where we've been doing the wrong
thing:

* git_config_parse_parameter() hasn't been setting config source
  information, so plumb "kvi" there too.

* Several sites in builtin/config.c have been calling current_config_*()
  functions outside of config callbacks (indirectly, via the
  format_config() helper), which means they're reading state that isn't
  set correctly:

  * "git config --get-urlmatch --show-scope" iterates config to collect
    values, but then attempts to display the scope after config
    iteration, causing the "unknown" scope to be shown instead of the
    config file's scope. It's clear that this wasn't intended: we knew
    that "--get-urlmatch" couldn't show config source metadata, which is
    why "--show-origin" was marked incompatible with "--get-urlmatch"
    when it was introduced [1]. It was most likely a mistake that we
    allowed "--show-scope" to sneak through.

    Fix this by copying the "kvi" value in the collection phase so that
    it can be read back later. This means that we can now support "git
    config --get-urlmatch --show-origin", but that is left unchanged
    for now.

  * "git config --default" doesn't have config source metadata when
    displaying the default value, so "--show-scope" also results in
    "unknown", and "--show-origin" results in a BUG(). Fix this by
    treating the default value as if it came from the command line (e.g.
    like we do with "git -c" or "git config --file"), using
    kvi_from_param().

[1] https://lore.kernel.org/git/20160205112001.GA13397@sigill.intra.peff.net/

Signed-off-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
@chooglen @gitster
chooglen authored and gitster committed Jun 28, 2023
1 parent 809d868 commit 26b6693
Show file tree
Hide file tree
Showing 4 changed files with 99 additions and 58 deletions.
47 changes: 30 additions & 17 deletions builtin/config.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -194,38 +194,42 @@ static void check_argc(int argc, int min, int max)
usage_builtin_config();
}

static void show_config_origin(struct strbuf *buf)
static void show_config_origin(const struct key_value_info *kvi,
struct strbuf *buf)
{
const char term = end_nul ? '\0' : '\t';

strbuf_addstr(buf, current_config_origin_type());
strbuf_addstr(buf, config_origin_type_name(kvi->origin_type));
strbuf_addch(buf, ':');
if (end_nul)
strbuf_addstr(buf, current_config_name());
strbuf_addstr(buf, kvi->filename ? kvi->filename : "");
else
quote_c_style(current_config_name(), buf, NULL, 0);
quote_c_style(kvi->filename ? kvi->filename : "", buf, NULL, 0);
strbuf_addch(buf, term);
}

static void show_config_scope(struct strbuf *buf)
static void show_config_scope(const struct key_value_info *kvi,
struct strbuf *buf)
{
const char term = end_nul ? '\0' : '\t';
const char *scope = config_scope_name(current_config_scope());
const char *scope = config_scope_name(kvi->scope);

strbuf_addstr(buf, N_(scope));
strbuf_addch(buf, term);
}

static int show_all_config(const char *key_, const char *value_,
const struct config_context *ctx UNUSED,
const struct config_context *ctx,
void *cb UNUSED)
{
const struct key_value_info *kvi = ctx->kvi;

if (show_origin || show_scope) {
struct strbuf buf = STRBUF_INIT;
if (show_scope)
show_config_scope(&buf);
show_config_scope(kvi, &buf);
if (show_origin)
show_config_origin(&buf);
show_config_origin(kvi, &buf);
/* Use fwrite as "buf" can contain \0's if "end_null" is set. */
fwrite(buf.buf, 1, buf.len, stdout);
strbuf_release(&buf);
Expand All @@ -243,12 +247,13 @@ struct strbuf_list {
int alloc;
};

static int format_config(struct strbuf *buf, const char *key_, const char *value_)
static int format_config(struct strbuf *buf, const char *key_,
const char *value_, const struct key_value_info *kvi)
{
if (show_scope)
show_config_scope(buf);
show_config_scope(kvi, buf);
if (show_origin)
show_config_origin(buf);
show_config_origin(kvi, buf);
if (show_keys)
strbuf_addstr(buf, key_);
if (!omit_values) {
Expand Down Expand Up @@ -303,9 +308,10 @@ static int format_config(struct strbuf *buf, const char *key_, const char *value
}

static int collect_config(const char *key_, const char *value_,
const struct config_context *ctx UNUSED, void *cb)
const struct config_context *ctx, void *cb)
{
struct strbuf_list *values = cb;
const struct key_value_info *kvi = ctx->kvi;

if (!use_key_regexp && strcmp(key_, key))
return 0;
Expand All @@ -320,7 +326,7 @@ static int collect_config(const char *key_, const char *value_,
ALLOC_GROW(values->items, values->nr + 1, values->alloc);
strbuf_init(&values->items[values->nr], 0);

return format_config(&values->items[values->nr++], key_, value_);
return format_config(&values->items[values->nr++], key_, value_, kvi);
}

static int get_value(const char *key_, const char *regex_, unsigned flags)
Expand Down Expand Up @@ -382,11 +388,14 @@ static int get_value(const char *key_, const char *regex_, unsigned flags)
&config_options);

if (!values.nr && default_value) {
struct key_value_info kvi = KVI_INIT;
struct strbuf *item;

kvi_from_param(&kvi);
ALLOC_GROW(values.items, values.nr + 1, values.alloc);
item = &values.items[values.nr++];
strbuf_init(item, 0);
if (format_config(item, key_, default_value) < 0)
if (format_config(item, key_, default_value, &kvi) < 0)
die(_("failed to format default config value: %s"),
default_value);
}
Expand Down Expand Up @@ -563,15 +572,17 @@ static void check_write(void)
struct urlmatch_current_candidate_value {
char value_is_null;
struct strbuf value;
struct key_value_info kvi;
};

static int urlmatch_collect_fn(const char *var, const char *value,
const struct config_context *ctx UNUSED,
const struct config_context *ctx,
void *cb)
{
struct string_list *values = cb;
struct string_list_item *item = string_list_insert(values, var);
struct urlmatch_current_candidate_value *matched = item->util;
const struct key_value_info *kvi = ctx->kvi;

if (!matched) {
matched = xmalloc(sizeof(*matched));
Expand All @@ -580,6 +591,7 @@ static int urlmatch_collect_fn(const char *var, const char *value,
} else {
strbuf_reset(&matched->value);
}
matched->kvi = *kvi;

if (value) {
strbuf_addstr(&matched->value, value);
Expand Down Expand Up @@ -627,7 +639,8 @@ static int get_urlmatch(const char *var, const char *url)
struct strbuf buf = STRBUF_INIT;

format_config(&buf, item->string,
matched->value_is_null ? NULL : matched->value.buf);
matched->value_is_null ? NULL : matched->value.buf,
&matched->kvi);
fwrite(buf.buf, 1, buf.len, stdout);
strbuf_release(&buf);

Expand Down
80 changes: 41 additions & 39 deletions config.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,9 @@ static const char include_depth_advice[] = N_(
"from\n"
" %s\n"
"This might be due to circular includes.");
static int handle_path_include(struct config_source *cs, const char *path,
static int handle_path_include(struct config_source *cs,
const struct key_value_info *kvi,
const char *path,
struct config_include_data *inc)
{
int ret = 0;
Expand Down Expand Up @@ -260,8 +262,7 @@ static int handle_path_include(struct config_source *cs, const char *path,
cs->name ? cs->name :
"the command line");
ret = git_config_from_file_with_options(git_config_include, path, inc,
current_config_scope(),
NULL);
kvi->scope, NULL);
inc->depth--;
}
cleanup:
Expand Down Expand Up @@ -510,7 +511,7 @@ static int git_config_include(const char *var, const char *value,
return ret;

if (!strcmp(var, "include.path"))
ret = handle_path_include(cs, value, inc);
ret = handle_path_include(cs, ctx->kvi, value, inc);

if (!parse_config_key(var, "includeif", &cond, &cond_len, &key) &&
cond && include_condition_is_true(cs, inc, cond, cond_len) &&
Expand All @@ -519,7 +520,7 @@ static int git_config_include(const char *var, const char *value,

if (inc->opts->unconditional_remote_url)
inc->fn = forbid_remote_url;
ret = handle_path_include(cs, value, inc);
ret = handle_path_include(cs, ctx->kvi, value, inc);
inc->fn = old_fn;
}

Expand Down Expand Up @@ -677,27 +678,44 @@ int git_config_parse_key(const char *key, char **store_key, size_t *baselen_)
}

static int config_parse_pair(const char *key, const char *value,
config_fn_t fn, void *data)
struct key_value_info *kvi,
config_fn_t fn, void *data)
{
char *canonical_name;
int ret;
struct config_context ctx = {
.kvi = kvi,
};

if (!strlen(key))
return error(_("empty config key"));
if (git_config_parse_key(key, &canonical_name, NULL))
return -1;

ret = (fn(canonical_name, value, NULL, data) < 0) ? -1 : 0;
ret = (fn(canonical_name, value, &ctx, data) < 0) ? -1 : 0;
free(canonical_name);
return ret;
}


/* for values read from `git_config_from_parameters()` */
void kvi_from_param(struct key_value_info *out)
{
out->filename = NULL;
out->linenr = -1;
out->origin_type = CONFIG_ORIGIN_CMDLINE;
out->scope = CONFIG_SCOPE_COMMAND;
}

int git_config_parse_parameter(const char *text,
config_fn_t fn, void *data)
{
const char *value;
struct strbuf **pair;
int ret;
struct key_value_info kvi = KVI_INIT;

kvi_from_param(&kvi);

pair = strbuf_split_str(text, '=', 2);
if (!pair[0])
Expand All @@ -716,12 +734,13 @@ int git_config_parse_parameter(const char *text,
return error(_("bogus config parameter: %s"), text);
}

ret = config_parse_pair(pair[0]->buf, value, fn, data);
ret = config_parse_pair(pair[0]->buf, value, &kvi, fn, data);
strbuf_list_free(pair);
return ret;
}

static int parse_config_env_list(char *env, config_fn_t fn, void *data)
static int parse_config_env_list(char *env, struct key_value_info *kvi,
config_fn_t fn, void *data)
{
char *cur = env;
while (cur && *cur) {
Expand Down Expand Up @@ -755,7 +774,7 @@ static int parse_config_env_list(char *env, config_fn_t fn, void *data)
CONFIG_DATA_ENVIRONMENT);
}

if (config_parse_pair(key, value, fn, data) < 0)
if (config_parse_pair(key, value, kvi, fn, data) < 0)
return -1;
}
else {
Expand All @@ -780,10 +799,13 @@ int git_config_from_parameters(config_fn_t fn, void *data)
int ret = 0;
char *envw = NULL;
struct config_source source = CONFIG_SOURCE_INIT;
struct key_value_info kvi = KVI_INIT;

source.origin_type = CONFIG_ORIGIN_CMDLINE;
config_reader_push_source(&the_reader, &source);

kvi_from_param(&kvi);

env = getenv(CONFIG_COUNT_ENVIRONMENT);
if (env) {
unsigned long count;
Expand Down Expand Up @@ -819,7 +841,7 @@ int git_config_from_parameters(config_fn_t fn, void *data)
}
strbuf_reset(&envvar);

if (config_parse_pair(key, value, fn, data) < 0) {
if (config_parse_pair(key, value, &kvi, fn, data) < 0) {
ret = -1;
goto out;
}
Expand All @@ -830,7 +852,7 @@ int git_config_from_parameters(config_fn_t fn, void *data)
if (env) {
/* sq_dequote will write over it */
envw = xstrdup(env);
if (parse_config_env_list(envw, fn, data) < 0) {
if (parse_config_env_list(envw, &kvi, fn, data) < 0) {
ret = -1;
goto out;
}
Expand Down Expand Up @@ -2442,7 +2464,8 @@ static int configset_find_element(struct config_set *set, const char *key,
return 0;
}

static int configset_add_value(struct config_reader *reader,
static int configset_add_value(const struct key_value_info *kvi_p,
struct config_reader *reader,
struct config_set *set, const char *key,
const char *value)
{
Expand Down Expand Up @@ -2476,13 +2499,9 @@ static int configset_add_value(struct config_reader *reader,
if (!reader->source)
BUG("configset_add_value has no source");
if (reader->source->name) {
kvi_from_source(reader->source, current_config_scope(), kv_info);
kvi_from_source(reader->source, kvi_p->scope, kv_info);
} else {
/* for values read from `git_config_from_parameters()` */
kv_info->filename = NULL;
kv_info->linenr = -1;
kv_info->origin_type = CONFIG_ORIGIN_CMDLINE;
kv_info->scope = reader->parsing_scope;
kvi_from_param(kv_info);
}
si->util = kv_info;

Expand Down Expand Up @@ -2538,11 +2557,12 @@ struct configset_add_data {
#define CONFIGSET_ADD_INIT { 0 }

static int config_set_callback(const char *key, const char *value,
const struct config_context *ctx UNUSED,
const struct config_context *ctx,
void *cb)
{
struct configset_add_data *data = cb;
configset_add_value(data->config_reader, data->config_set, key, value);
configset_add_value(ctx->kvi, data->config_reader, data->config_set,
key, value);
return 0;
}

Expand Down Expand Up @@ -4037,16 +4057,6 @@ const char *config_origin_type_name(enum config_origin_type type)
}
}

const char *current_config_origin_type(void)
{
enum config_origin_type type = CONFIG_ORIGIN_UNKNOWN;

if (reader_origin_type(&the_reader, &type))
BUG("current_config_origin_type called outside config callback");

return config_origin_type_name(type);
}

const char *config_scope_name(enum config_scope scope)
{
switch (scope) {
Expand Down Expand Up @@ -4078,14 +4088,6 @@ static int reader_config_name(struct config_reader *reader, const char **out)
return 0;
}

const char *current_config_name(void)
{
const char *name;
if (reader_config_name(&the_reader, &name))
BUG("current_config_name called outside config callback");
return name ? name : "";
}

enum config_scope current_config_scope(void)
{
if (the_reader.config_kvi)
Expand Down
3 changes: 1 addition & 2 deletions config.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,8 @@ void git_global_config(char **user, char **xdg);
int git_config_parse_parameter(const char *, config_fn_t fn, void *data);

enum config_scope current_config_scope(void);
const char *current_config_origin_type(void);
const char *current_config_name(void);
const char *config_origin_type_name(enum config_origin_type type);
void kvi_from_param(struct key_value_info *out);

/*
* Match and parse a config key of the form:
Expand Down
Loading

0 comments on commit 26b6693

Please sign in to comment.