Skip to content

Commit

Permalink
ci: also run the scalar tests
Browse files Browse the repository at this point in the history
Since Scalar depends on `libgit.a`, it makes sense to ensure in the CI
and the PR builds that it does not get broken in case of industrious
refactorings of the core Git code (speaking from experience here).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Sep 22, 2022
1 parent cd50d56 commit 6be1479
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 2 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ jobs:
HOME: ${{runner.workspace}}
NO_PERL: 1
run: . /etc/profile && ci/make-test-artifacts.sh artifacts
- name: build Scalar
shell: bash
run: |
make -C contrib/scalar &&
mkdir -p artifacts/bin-wrappers artifacts/contrib/scalar &&
cp contrib/scalar/scalar.exe artifacts/contrib/scalar/ &&
cp bin-wrappers/scalar artifacts/bin-wrappers/
- name: zip up tracked files
run: git archive -o artifacts/tracked.tar.gz HEAD
- name: upload tracked files and build artifacts
Expand Down Expand Up @@ -160,6 +167,8 @@ jobs:
run: compat\vcbuild\vcpkg_copy_dlls.bat release ${{ matrix.arch }}-windows
- name: generate Visual Studio solution
shell: bash
env:
INCLUDE_SCALAR: YesPlease
run: |
cmake `pwd`/contrib/buildsystems/ -DCMAKE_PREFIX_PATH=`pwd`/compat/vcbuild/vcpkg/installed/${{ matrix.arch }}-windows \
-DNO_GETTEXT=YesPlease -DPERL_TESTS=OFF -DPYTHON_TESTS=OFF -DCURL_NO_CURL_CMAKE=ON -DCMAKE_GENERATOR_PLATFORM=${{ matrix.arch }} -DVCPKG_ARCH=${{ matrix.arch }}-windows -DHOST_CPU=${{ matrix.arch }}
Expand All @@ -173,6 +182,12 @@ jobs:
run: |
mkdir -p artifacts &&
eval "$(make -n artifacts-tar INCLUDE_DLLS_IN_ARTIFACTS=YesPlease ARTIFACTS_DIRECTORY=artifacts NO_GETTEXT=YesPlease 2>&1 | grep ^tar)"
- name: copy Scalar
shell: bash
run: |
mkdir -p artifacts/bin-wrappers artifacts/contrib/scalar &&
cp contrib/scalar/scalar.exe artifacts/contrib/scalar/ &&
cp bin-wrappers/scalar artifacts/bin-wrappers/
- name: zip up tracked files
run: git archive -o artifacts/tracked.tar.gz HEAD
- name: upload tracked files and build artifacts
Expand Down
2 changes: 2 additions & 0 deletions ci/run-build-and-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,6 @@ case " $MAKE_TARGETS " in
*" all "*) make -C contrib/subtree test;;
esac

make -C contrib/scalar $MAKE_TARGETS

save_good_tree
8 changes: 6 additions & 2 deletions ci/run-test-slice.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ group "Run tests" make --quiet -C t T="$(cd t &&
tr '\n' ' ')" ||
handle_failed_tests

# Run the git subtree tests only if main tests succeeded
test 0 != "$1" || make -C contrib/subtree test
if test 0 = "$1"
then
# Run the git subtree & scalar tests only if main tests succeeded
make -C contrib/subtree test &&
make -C contrib/scalar test
fi

check_unignored_build_artifacts

0 comments on commit 6be1479

Please sign in to comment.