Skip to content

Commit

Permalink
gitk: check main window visibility before waiting for it to show (#705)
Browse files Browse the repository at this point in the history
If the main window is already visible when gitk waits for it to become
visible, gitk hangs forever.
This commit adds a check whether the window is already visible. See
https://wiki.tcl-lang.org/page/tkwait+visibility

This ports git#944 to `microsoft/git`. for
Git.

Fixed issue #704.
  • Loading branch information
dscho authored Nov 13, 2024
2 parents 90d5460 + 2797cd5 commit e1c75f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gitk-git/gitk
Original file line number Diff line number Diff line change
Expand Up @@ -12832,7 +12832,7 @@ if {$::tcl_platform(platform) eq {windows} && [file exists $gitk_prefix/etc/git.
}
}
# wait for the window to become visible
tkwait visibility .
if {![winfo viewable .]} {tkwait visibility .}
set_window_title
update
readrefs
Expand Down

0 comments on commit e1c75f9

Please sign in to comment.