Skip to content

Commit

Permalink
unpack-trees: fix nested sparse-dir search
Browse files Browse the repository at this point in the history
The iterated search in find_cache_entry() was recently modified to
include a loop that searches backwards for a sparse directory entry that
matches the given traverse_info and name_entry. However, the string
comparison failed to actually concatenate those two strings, so this
failed to find a sparse directory when it was not a top-level directory.

This caused some errors in rare cases where a 'git checkout' spanned a
diff that modified files within the sparse directory entry, but we could
not correctly find the entry.

Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Helped-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
  • Loading branch information
derrickstolee committed Aug 24, 2021
1 parent 2974920 commit e7cdaa0
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions unpack-trees.c
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,8 @@ static int sparse_dir_matches_path(const struct cache_entry *ce,
static struct cache_entry *find_cache_entry(struct traverse_info *info,
const struct name_entry *p)
{
struct cache_entry *ce;
const char *path;
struct cache_entry *ce = NULL;
int pos = find_cache_pos(info, p->path, p->pathlen);
struct unpack_trees_options *o = info->data;

Expand Down Expand Up @@ -1283,7 +1284,9 @@ static struct cache_entry *find_cache_entry(struct traverse_info *info,
while (pos >= 0) {
ce = o->src_index->cache[pos];

if (strncmp(ce->name, p->path, p->pathlen))
if (!skip_prefix(ce->name, info->traverse_path, &path) ||
strncmp(path, p->path, p->pathlen) ||
path[p->pathlen] != '/')
return NULL;

if (S_ISSPARSEDIR(ce->ce_mode) &&
Expand Down

0 comments on commit e7cdaa0

Please sign in to comment.