fixup! pager: fix order of atexit() calls #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f58806 as it no longer fixes the underlying issue. Signed-off-by: Ben Peart <benpeart@microsoft.com>
kewillford
reviewed
Feb 13, 2019
IIRC was just to enable getting the trace output. It doesn't have any impact on the post-command hook. I've verified it still passes the pre and post-command hook tests just to be sure. |
kewillford
approved these changes
Feb 13, 2019
|
Did it not also have something to do with tracing in the post-command hook? |
|
I discovered (and fixed) the problem debugging the post-command hook but the post-command hook itself doesn't need/require it. The "fix" got broken at some point since then and doesn't work anymore anyway. :( |
Okay, then. Thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of housekeeping to reduce the number of patches in our fork. This reverts commit 3f58806 as it no longer fixes the underlying issue so there is no reason to keep hauling it along with every release.
Signed-off-by: Ben Peart benpeart@microsoft.com