[WIP] sparse-checkout: basics of builtin #171
Conversation
|
I realize that this is a WIP and not necessarily what will go upstream so this is mainly a suggestion of how we could get it more quickly accepted upstream. I think we need to help how sparse-checkout works as is and then enhance what the built-in does from there. So the first cut would add and remove entries as is to the sparse-checkout and turn the feature on and off. Not sure if we would turn on as soon as someone adds something and turn off if the last entry is removed or have a different command they have to run. Turn on could just be setting the Turning off is a little more tricky because it would be nice if we could help
So we would have to add only I would think upstream would have little push back since it is really helping the sparse-checkout feature. We could then add more "enhancements" on top of it. |
derrickstolee
force-pushed
the
sparse-checkout/head
branch
from
4a6a26d
to
60c94e9
Compare
I appreciate the feedback, @kewillford!
You are right that we should give more respect to the feature and how it works right now, then build on it. The problem I'm balancing right now is that we need a "restricted patterns" mode for faster performance. My current focus is on making that work first, then generalizing to the full feature.
Perhaps the
I have no problem with this idea: call it
Your ideas are a great first step. I do want some feedback on the full vision before getting anything else upstream, so I'll prepare an RFC whose first commits do as you suggest, but later commits give the full feature (including the performance boosts). |
| return -1; /* undecided */ | ||
| } | ||
|
|
||
| strbuf_addch(&parent_pathname, '/'); |
There was a problem hiding this comment.
@wilbaker here is where the new "fast" pattern matching logic is.
Implements init, add, and list. Save 'remove' for later. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
sparse-checkout/head
branch
from
dbf77b4
to
83927a1
Compare
I'm creating this PR for a fourth time (see #163, #171, and #178 for earlier versions). This version is tracking my progress to create something that can be sent as an RFC upstream, but also can be used to start the sparse feature branch. This is based on v2.23.0. Note: I currently have conflicts with the virtual filesystem feature, and I'll resolve those with a merge commit when I'm ready. I'm just creating this for tracking progress at the moment, but can also be a place for early feedback. * git sparse-checkout disable to disable the sparse-checkout feature and return to a full checkout. * git sparse-checkout init --cone, to initialize in cone mode. * git sparse-checkout add when core.sparseCheckout=cone. This includes performance improvements with the hashset-based matching algorithm, but I'll leave further enhancements as smaller steps on top. Here are a few things I want to try: Track the maximum depth of a prefix pattern, so we know to not run hashes for deeper paths. Use the "known exclude" bit in cone mode to stop hashing paths we know will not be included. Use the "known include" bit in cone mode to stop hashing paths we know will be included. This is more difficult than "known exclude" because we need to distinguish directories from files when doing path matches so we don't give a directory a "known include" when it isn't a recursive pattern match.
Implements init, add, and list. Save 'remove' for later. Creating the PR to get initial feedback, build an installer, and do some testing in the microsoft/[redacted] repo.