Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvfs-helper: retry when creating temp files #231

Merged
merged 1 commit into from
Dec 31, 2019
Merged

gvfs-helper: retry when creating temp files #231

merged 1 commit into from
Dec 31, 2019

Conversation

derrickstolee
Copy link
Collaborator

When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-" suffix to the
name before the ".temp".

This is a follow-up to #229.

@derrickstolee
gvfs-helper: retry when creating temp files
789f5dd 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee mentioned this pull request Dec 26, 2019
Merged
jeffhostetler
jeffhostetler approved these changes Dec 30, 2019
View reviewed changes
Copy link

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! We got a collision in the concurrent test suite even with the microsecond value in the basename.

@jeffhostetler
Copy link

as an alternative, we could encode the PID in the tempfile pathname.

@derrickstolee derrickstolee merged commit ccc87aa into microsoft:vfs-2.24.1 Dec 31, 2019
derrickstolee added a commit to microsoft/scalar that referenced this pull request Dec 31, 2019
@derrickstolee
Merge pull request #267: Update Git to include concurrent pack-file fix
da9868e 
These updates allow the gvfs-helper to be more resilient to concurrent pack downloads.

See microsoft/git#229 and microsoft/git#231 for more details.
derrickstolee added a commit that referenced this pull request Jan 14, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
8799930 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Feb 21, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
3b9ff2a 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Mar 17, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
f650135 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Mar 23, 2020
@derrickstolee
Merge pull request #231: gvfs-helper: retry when creating temp files
811c65f 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
dscho pushed a commit that referenced this pull request May 20, 2020
@derrickstolee @dscho
Merge pull request #231: gvfs-helper: retry when creating temp files
63f7f64 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
dscho pushed a commit that referenced this pull request May 20, 2020
@derrickstolee @dscho
Merge pull request #231: gvfs-helper: retry when creating temp files
1f6c438 
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.

Retry the temp pack names using a new "-<retry>" suffix to the
name before the ".temp".

This is a follow-up to #229.
derrickstolee added a commit that referenced this pull request Jun 1, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
b0950dc 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Jul 20, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
0a4e78d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Jul 27, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
24dfc0d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Jul 28, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
17ff6eb 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Oct 6, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
a2e1c7e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Oct 6, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
852db15 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 6, 2020
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
982a3d1 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee added a commit that referenced this pull request Oct 9, 2020
@derrickstolee
Merge gvfs-helper prefetch feature
8dfbaf4 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit that referenced this pull request Jul 19, 2023
@derrickstolee @vdye
Merge gvfs-helper prefetch feature
9632459 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 8, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
7eddf25 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 8, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
b0fa666 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Aug 11, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
c82cf24 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jeffhostetler pushed a commit that referenced this pull request Aug 23, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
b1d2c0f 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 3, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
3e8f41d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 3, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
a882931 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 3, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
2e6950c 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 8, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
2327009 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 14, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
55dfd53 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Nov 20, 2023
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
564da1d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit that referenced this pull request Feb 27, 2024
@derrickstolee @vdye
Merge gvfs-helper prefetch feature
53ab4c1 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Apr 23, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
4b4862d 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Apr 23, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
942e54c 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Apr 23, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
9e0209c 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Apr 24, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
6a7e63e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Apr 29, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
8c62b8e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request May 14, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
09308cf 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request May 14, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
9421953 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jun 3, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
2afd917 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jul 17, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
e597a9b 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jul 17, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
826c549 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jul 17, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
f5f8a36 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jul 18, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
82924bc 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Jul 23, 2024
@derrickstolee @mjcheetham
Merge gvfs-helper prefetch feature
1188a9b 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Jul 25, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
7d37f0e 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Jul 29, 2024
@derrickstolee @mjcheetham
Merge gvfs-helper prefetch feature
d3f7d4a 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Sep 18, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
44414fa 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Sep 24, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
f1d42e1 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho pushed a commit that referenced this pull request Oct 8, 2024
@derrickstolee @dscho
Merge gvfs-helper prefetch feature
9a20ba6 
Includes these pull requests:

 #227
 #228
 #229
 #231
 #240

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffhostetler jeffhostetler jeffhostetler approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrickstolee @jeffhostetler