Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding winget workflow #328

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

ldennington
Copy link

Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a PR against my winget-playground repo and running winget validate to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (*cough* ShortDescription: *cough*) or suggestions for additional fields/values are welcome!

@ldennington ldennington changed the title Add winget workflow Adding winget workflow Apr 29, 2021
.github/workflows/release-winget.yaml Outdated Show resolved Hide resolved
.github/workflows/release-winget.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge. We could consider adding a longer Description: text, but that can wait (if we even think it is necessary).

@ldennington
Copy link
Author

I think this is ready to merge. We could consider adding a longer Description: text, but that can wait (if we even think it is necessary).

Yay!!! So exciting! I'll wait until checks have completed then merge.

@derrickstolee
Copy link
Collaborator

Apparently the builds have been updated to not re-run on a tree where the build is known to succeed, but instead of reporting "success" it reports "skipped". I will merge this PR without the green builds.

@dscho: are you aware of this issue? I know you have a lot of experience with these builds.

@derrickstolee derrickstolee merged commit 62789e7 into microsoft:vfs-2.31.1 Apr 30, 2021
@ldennington
Copy link
Author

Apparently the builds have been updated to not re-run on a tree where the build is known to succeed, but instead of reporting "success" it reports "skipped". I will merge this PR without the green builds.

@dscho: are you aware of this issue? I know you have a lot of experience with these builds.

Thank you!!

@dscho
Copy link
Member

dscho commented May 5, 2021

Apparently the builds have been updated to not re-run on a tree where the build is known to succeed, but instead of reporting "success" it reports "skipped". I will merge this PR without the green builds.

@dscho: are you aware of this issue? I know you have a lot of experience with these builds.

I am the reason for this: 7d78d5f. It is too bad that we cannot make the branch protection dependent on the overall workflow. In my mind, it is a shortcoming of GitHub Actions that you can only require individual jobs to pass...

derrickstolee added a commit that referenced this pull request May 17, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request May 21, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request May 22, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request May 22, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request May 28, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request Jun 2, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request Jun 7, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Aug 3, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Aug 3, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request Aug 5, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Aug 9, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Aug 12, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Aug 17, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request Oct 30, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Oct 30, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Oct 31, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Nov 4, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Nov 10, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Nov 15, 2021
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 12, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 19, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 25, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request Feb 1, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
derrickstolee added a commit that referenced this pull request Jun 16, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
dscho pushed a commit that referenced this pull request Jun 17, 2022
Adding a shiny new workflow to publish releases to winget! 🥳

I validated this workflow locally by successfully opening a [PR](https://github.com/ldennington/winget-playground/pull/4) against my winget-playground repo and running `winget validate` to ensure the generated manifest adheres to winget's required schema. Any feedback on the fields I've included (\*cough\* `ShortDescription:` \*cough\*) or suggestions for additional fields/values are welcome!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants