Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sane_execvp in git rebase and git stash #36

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Avoid sane_execvp in git rebase and git stash #36

merged 1 commit into from
Oct 12, 2018

Commits on Oct 12, 2018

  1. rebase/stash: make post-command hook work again 

    William Baker reported that the non-built-in rebase and stash fail to
run the post-command hook (which is important for VFS for Git, though).

The reason is that an `exec()` will replace the current process by the
newly-exec'ed one (our Windows-specific emulation cannot do that, and
does not even try, so this is only an issue on Linux/macOS). As a
consequence, not even the atexit() handlers are run, including the
one running the post-command hook.

To work around that, let's spawn the legacy rebase/stash and exit with
the reported exit code.
    @dscho
    dscho committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    baa8cd0 View commit details
    Browse the repository at this point in the history