gvfs-helper: always keep index-pack silent #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how we are calling 'git index-pack' and piping stdout, I found an instance where our 'git index-pack' subcommand is timing out. Since we are using pipe_command() to get the stdout and use that hash to create a new filename, the 'ip.stderr = -1' line breaks the expected behavior, especially when providing '-v'. Let's be more careful about stderr when cloning. The case I saw was for using the prefetch endpoint on Azure Repos on a repo that doesn't have configured cache servers. The pack-file was over 1GB so the progress indicator reliably hit a problem. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
prefetch-index-pack
branch
from
36f4465
to
73ed7c8
Compare
dscho
approved these changes
Jun 15, 2021
jeffhostetler
approved these changes
Jun 16, 2021
|
Thanks for the reviews! I'm merging despite a flaky Scalar functional test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how we are calling 'git index-pack' and piping stdout, I found an
instance where our 'git index-pack' subcommand is timing out. Since we
are using pipe_command() to get the stdout and use that hash to create
a new filename, the 'ip.stderr = -1' line breaks the expected behavior,
especially when providing '-v'.
Let's be more careful about stderr when cloning.
The case I saw was for using the prefetch endpoint on Azure Repos on a
repo that doesn't have configured cache servers. The pack-file was over
1GB so the progress indicator reliably hit a problem.