Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-apt-get workflow #386

Merged

Conversation

ldennington
Copy link

@ldennington ldennington commented Jun 21, 2021

Adding workflow to microsoft/git to release to Microsoft's official repositories for Ubuntu distributions we currently support: HIRSUTE (21.04, aka latest) and BIONIC (18.04, aka latest LTS). Details for the reasons behind this change can be found here.

Note: This is the same flow you can already find in GCM Core, minus signing, since our build takes care of that on our hehalf. I've also validated this flow in my fork to create successful bionic and hirsute releases.

@ldennington ldennington self-assigned this Jun 21, 2021
@ldennington ldennington force-pushed the add-release-apt-get-workflow branch from ae9dc32 to c4b9d40 Compare June 21, 2021 18:59
@ldennington ldennington changed the title Add release apt-get workflow Add release-apt-get workflow Jun 21, 2021
Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the code and nothing looks strange, other than the things that seem like they are required to look strange. There's an interesting indirection that I mention in a comment, but don't spend too much time thinking about that.

.github/workflows/release-apt-get.yml Show resolved Hide resolved
.github/workflows/release-apt-get.yml Outdated Show resolved Hide resolved
.github/configure_repoclient.py Outdated Show resolved Hide resolved
.github/workflows/release-apt-get.yml Outdated Show resolved Hide resolved
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 💋

@ldennington ldennington force-pushed the add-release-apt-get-workflow branch 2 times, most recently from 544731f to 5427bda Compare June 25, 2021 18:50
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things I noticed.

.github/workflows/release-apt-get.yml Outdated Show resolved Hide resolved
.github/workflows/release-apt-get.yml Outdated Show resolved Hide resolved
.github/workflows/release-apt-get.yml Outdated Show resolved Hide resolved
.github/workflows/release-apt-get.yml Outdated Show resolved Hide resolved
@ldennington ldennington force-pushed the add-release-apt-get-workflow branch 2 times, most recently from 086e08d to b724211 Compare June 26, 2021 19:17
This adds support for releasing to Ubuntu repositories hosted
at http://packages.microsoft.com/ (hosting location for Microsoft's
official apt/yum repos). This allows users to install via apt-get on
Hirsute/Bionic. Details to configure appropriate repos can be found
here:

https://docs.microsoft.com/en-us/windows-server/administration/Linux-Package-Repository-for-Microsoft-Software).
@ldennington ldennington merged commit 403bcde into microsoft:vfs-2.32.0 Jun 28, 2021
derrickstolee pushed a commit that referenced this pull request Aug 3, 2021
derrickstolee pushed a commit that referenced this pull request Aug 3, 2021
derrickstolee pushed a commit that referenced this pull request Aug 5, 2021
dscho pushed a commit that referenced this pull request Aug 5, 2021
derrickstolee pushed a commit that referenced this pull request Aug 9, 2021
derrickstolee pushed a commit that referenced this pull request Aug 9, 2021
derrickstolee pushed a commit that referenced this pull request Aug 9, 2021
derrickstolee pushed a commit that referenced this pull request Aug 12, 2021
derrickstolee pushed a commit that referenced this pull request Aug 17, 2021
dscho pushed a commit that referenced this pull request Oct 30, 2021
derrickstolee pushed a commit that referenced this pull request Oct 30, 2021
derrickstolee pushed a commit that referenced this pull request Oct 31, 2021
derrickstolee pushed a commit that referenced this pull request Nov 4, 2021
derrickstolee pushed a commit that referenced this pull request Nov 10, 2021
derrickstolee pushed a commit that referenced this pull request Nov 15, 2021
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 12, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 19, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 20, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 25, 2022
ldennington pushed a commit to ldennington/git that referenced this pull request Jan 25, 2022
dscho pushed a commit that referenced this pull request Feb 1, 2022
dscho pushed a commit that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants