Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix winget tag specification #387

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix winget tag specification #387

merged 1 commit into from
Jun 21, 2021

Conversation

ldennington
Copy link
Collaborator

@ldennington ldennington commented Jun 21, 2021 •
edited
Loading

According to a recent PR, the recommended format for winget tags has changed. Updating our manifest according to the new specification.

@dscho
Copy link
Member

dscho commented Jun 21, 2021

We probably want to squash this into dafa70b once the next Git for Windows version comes around and we rebase. It's not at all a big deal, but may I ask for future fixups to be marked up via a fixup! oneline? That way, git rebase -ir --autosquash will do the reordering and changing from pick to fixup for us.

@ldennington
Copy link
Collaborator Author

We probably want to squash this into dafa70b once the next Git for Windows version comes around and we rebase. It's not at all a big deal, but may I ask for future fixups to be marked up via a fixup! oneline? That way, git rebase -ir --autosquash will do the reordering and changing from pick to fixup for us.

I made the change to the commit - is that what you were looking for?

@dscho
Copy link
Member

dscho commented Jun 21, 2021

I made the change to the commit - is that what you were looking for?

Yes, thank you so much!

@ldennington ldennington merged commit 1bc9448 into microsoft:vfs-2.32.0 Jun 21, 2021
@derrickstolee derrickstolee mentioned this pull request Jun 22, 2021
Merged
derrickstolee added a commit that referenced this pull request Jun 22, 2021
@derrickstolee
Merge pull request #390: Fix whitespace errors
01e0fe8 
The builds are now complaining about a trailing whitespace introduced in #387. Not sure how it passed those builds, but this fixes it.
derrickstolee pushed a commit that referenced this pull request Aug 3, 2021
@derrickstolee
Merge pull request #387 from ldennington/fix-tag-formatting
b5664b8 
Fix winget tag specification
derrickstolee added a commit that referenced this pull request Aug 3, 2021
@derrickstolee
Merge pull request #390: Fix whitespace errors
f4bd275 
The builds are now complaining about a trailing whitespace introduced in #387. Not sure how it passed those builds, but this fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

@derrickstolee derrickstolee derrickstolee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldennington @dscho @derrickstolee