scalar: enable untracked cache unconditionally #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a successor of #382 and #383, right? I just tried to rebase #383's branch onto The diff between #383's errors and my rebased branch's errors is empty... |
|
Yes.
So your rebased branch does the following:
And with those, you get a failure. I will try one thing, which is to disable the FS Monitor and see if that leads to a failure. I don't expect that we will be disabling the FS Cache. |
|
So we got a failure with This means that in the case of a trivial response from the FS Monitor we might hit the untracked cache issue where the filesystem doesn't properly report a dir's mtime. Is the simultaneous failure of both systems rare enough to recommend untracked cache with FS Monitor? cc: @jeffhostetler for thoughts here. |
derrickstolee
force-pushed
the
untracked-cache-on
branch
from
0db094f
to
9cc15a9
Compare
derrickstolee
commented
Sep 1, 2021
| @@ -156,23 +156,7 @@ static int set_recommended_config(int reconfigure) | |||
| { "core.FSCache", "true", 1 }, | |||
| { "core.multiPackIndex", "true", 1 }, | |||
| { "core.preloadIndex", "true", 1 }, | |||
| #ifndef WIN32 | |||
| { "core.untrackedCache", "true", 1 }, | |||
There was a problem hiding this comment.
Since this sets overwrite_on_reconfigure, our users will upgrade successfully.
|
Ping @dscho, @jeffhostetler. I believe we agreed to merge this. Anyone want to provide a ✔️ ? |
dscho
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Sounds good.
It is a nice validation of the value of the FSMonitor patch series that this side-steps the issues that prevent the untracked cache from working properly.
And I am super excited that we can enable this for our users, it provides for such a boost in speed.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
The GIT_FORCE_UNTRACKED_CACHE environment variable write the untracked cache more frequently than the core.untrackedCache config variable. This is due to how read_directory() handles the creation of an untracked cache. The old mechanism required using something like 'git update-index --untracked-cache' before the index would actually contain an untracked cache. This was noted as a performance problem on macOS in the past, and this is the resolution for that issue. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
derrickstolee
force-pushed
the
untracked-cache-on
branch
from
9cc15a9
to
7e993e5
Compare
dscho
pushed a commit
that referenced
this pull request
Oct 30, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
derrickstolee
added a commit
that referenced
this pull request
Oct 30, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
derrickstolee
added a commit
that referenced
this pull request
Oct 31, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
derrickstolee
added a commit
that referenced
this pull request
Nov 4, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
derrickstolee
added a commit
that referenced
this pull request
Nov 4, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
derrickstolee
added a commit
that referenced
this pull request
Nov 10, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
derrickstolee
added a commit
that referenced
this pull request
Nov 15, 2021
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 12, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 19, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 25, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
ldennington
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 25, 2022
…nditionally No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
dscho
pushed a commit
that referenced
this pull request
Feb 1, 2022
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
dscho
pushed a commit
that referenced
this pull request
Jun 17, 2022
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
dscho
pushed a commit
that referenced
this pull request
Jun 17, 2022
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request: 1. Scalar enables the untracked cache unconditionally via `core.untrackedCache = true`. This was previously set to `false` on Windows. 2. Set `GIT_FORCE_UNTRACKED_CACHE=1` for the Scalar functional tests. 3. Update the `core.untrackedCache` config variable to be as strong as the `GIT_FORCE_UNTRACKED_CACHE` environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No matter what I try, I cannot get the untracked cache to fail on Windows. Here are the things that are done in this pull request:
core.untrackedCache = true. This was previously set tofalseon Windows.GIT_FORCE_UNTRACKED_CACHE=1for the Scalar functional tests.core.untrackedCacheconfig variable to be as strong as theGIT_FORCE_UNTRACKED_CACHEenvironment variable.