Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anticipate future VS versions in the release workflow #416

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Anticipate future VS versions in the release workflow #416

merged 1 commit into from
Sep 1, 2021

Conversation

dscho
Copy link
Member

@dscho dscho commented Aug 31, 2021

We hard-code for supported VS versions, but there really is not a lot we need to support, so let's include the next three versions preemptively.

@dscho dscho requested a review from mjcheetham August 31, 2021 14:01
derrickstolee
derrickstolee approved these changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope they stick to this pattern.

mjcheetham
mjcheetham reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS did ask about the possibility of a version-less key, but just setting the next 3 major versions "shouldn't hurt", right?

@dscho
Copy link
Member Author

dscho commented Aug 31, 2021

Whoops, I forgot the "uninstall" part.

@dscho
fixup! release: create initial Windows installer build workflow
78cb0b6 
This preemptively prepares our workflow for future VS versions.
@dscho
Copy link
Member Author

dscho commented Aug 31, 2021

Whoops, I forgot the "uninstall" part.

Fixed.

just setting the next 3 major versions "shouldn't hurt", right?

That was my thinking, indeed ;-)

@dscho dscho self-assigned this Sep 1, 2021
@dscho dscho merged commit a5b4290 into microsoft:vfs-2.33.0 Sep 1, 2021
@dscho dscho deleted the anticipate-vs-versions branch September 1, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcheetham mjcheetham mjcheetham left review comments

@derrickstolee derrickstolee derrickstolee approved these changes

Assignees

@dscho dscho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dscho @derrickstolee @mjcheetham