Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Git for Windows v2.33.0(2) #436

Merged
merged 9 commits into from
Oct 4, 2021

Conversation

dscho
Copy link
Member

@dscho dscho commented Oct 2, 2021

There have been a few fixups, nothing dramatic, and we should probably update vfs-2.33.0 to reflect those changes.

carenas and others added 9 commits August 15, 2021 09:45
e9f79ac (ci: upgrade to using actions/{up,down}load-artifacts v2,
2021-06-23) changed all calls to that action from v1 to v2, but there
is still an open bug[1] that affects all nodejs actions and prevents
its use in 32-bit linux (as used by the Linux32 container)

move all dockerized jobs to use v1 that was built in C# and therefore
doesn't have this problem, which will otherwise manifest with confusing
messages like:

  /usr/bin/docker exec  0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c "cat /etc/*release | grep ^ID"
  OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown

[1] actions/runner#1011

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This compile error fix was inadvertently squashed into 379fe49
(clean: remove mount points when possible, 2018-12-11), but actually
belongs into an earlier patch.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…em directory

The long-paths support comes later in Git for Windows' branch thicket...

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…pload-artifacts-v1

ci: use upload-artifacts v1 for dockerized jobs
This is needed to let the code compile without error.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This change was inadvertently kept in a patch that precedes the
`core.longPaths` support.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@derrickstolee derrickstolee merged commit d1c91db into microsoft:vfs-2.33.0 Oct 4, 2021
@dscho dscho deleted the vfs-2.33.0.2 branch October 5, 2021 08:57
dscho pushed a commit that referenced this pull request Oct 30, 2021
There have been a few fixups, nothing dramatic, and we should probably update `vfs-2.33.0` to reflect those changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants