Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: replace recently seen logic #445

Merged
merged 1 commit into from
Oct 14, 2021
Merged

.github: replace recently seen logic #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/build-git-installers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,10 @@ jobs:
run: |
set -x

b=/usr/src/build-extra &&
str="recently_seen=.*\$" &&

echo $b/git-extra/git-update-git-for-windows &&
cat $b/git-extra/git-update-git-for-windows &&
b=/mingw64/bin &&

sed -i -e '/^# when confirmation to do so is given./a\
use_recently_seen=no' \
$b/git-extra/git-update-git-for-windows
sed -i -e '6 a use_recently_seen=no' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the form that does not expect line number 6 to be the one, but that matches the line after which we want to append.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good news is that this area of the file is all comments, so inserting to a specific line is more stable than matching the text of a comment, hence the choice I made here.

$b/git-update-git-for-windows
derrickstolee marked this conversation as resolved.
Show resolved Hide resolved
- name: Set the installer Publisher to the Git Fundamentals team
shell: bash
run: |
Expand Down