Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintenance: delete stale lock files, fix loose-objects task #468

Merged
merged 2 commits into from
Nov 16, 2021
Merged

maintenance: delete stale lock files, fix loose-objects task #468

merged 2 commits into from
Nov 16, 2021

Commits on Nov 16, 2021

  1. maintenance: delete stale lock files 

    The maintenance.lock file exists to prevent concurrent maintenance
processes from writing to a repository at the same time. However, it has
the downside of causing maintenance to start failing without recovery if
there is any reason why the maintenance command failed without cleaning
up the lock-file.

This change makes it such that maintenance will delete a lock file that
was modified over 6 hours ago. This will auto-heal repositories that are
stuck with failed maintenance (and maybe it will fail again, but we will
get a message other than the lock file exists).

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
    @derrickstolee
    derrickstolee committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    bbceaa8 View commit details
    Browse the repository at this point in the history

  2. fixup! maintenance: care about gvfs.sharedCache config 

    The bug here is that object_dir was being set to an internal pointer
within git_config_get_value(), but then getting clobbered by the stack
or something. The xstrdup() here ensures that we don't lose the value
this way.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
    @derrickstolee
    derrickstolee committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    70c619f View commit details
    Browse the repository at this point in the history