fixup! homebrew: add GitHub workflow to release Cask #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially used pull requests for the Homebrew releases as a manual step to ensure that the automation didn't do anything too problematic. However, we are now manually approving something that has never failed. Let's just push directly to the branch, if possible, reducing the manual steps involved in the release process. Signed-off-by: Derrick Stolee <derrickstolee@github.com>
mjcheetham
approved these changes
May 31, 2022
There was a problem hiding this comment.
Looks good to me! As long as the user whose credentials the workflow runs with has permissions to push commits to the master branch in the Tap, this should work ok!
I believe that user would be me and I am an admin of the Tap repo in question, so should be good(!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initially used pull requests for the Homebrew releases as a manual
step to ensure that the automation didn't do anything too problematic.
However, we are now manually approving something that has never failed.
Let's just push directly to the branch, if possible, reducing the manual
steps involved in the release process.