New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update releases to work with new SSL certificate #520

Merged

ldennington merged 1 commit into microsoft:vfs-2.37.1 from ldennington:ssl-cert-updates

Jul 20, 2022

Collaborator

ldennington commented Jul 20, 2022 •

edited

Loading

This PR contains the required changes to use our new auto-rotating SSL certificate. There are two main parts:

Adding the "SendX5c" : "true" key value pair to the contents of our ESRP Auth Json file. This allows us to use the new auto-rotating certificate without having to upload/manage it from our App Registration.
Removing theAZURE_AAD_ID_SSL secret/environment variable. The new certificate was generated with our main AZURE_AAD_ID app registration, so this extra ID is no longer needed.

Here is a successful test run of the macOS workflow with these changes.


          fixup! fixup! release: add Mac OSX installer build

ldennington requested review from derrickstolee and vdye

July 20, 2022 19:02

ldennington self-assigned this

derrickstolee approved these changes

View reviewed changes

ldennington merged commit 196b322 into microsoft:vfs-2.37.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet