winget: auto-update license/copyright urls #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of our winget manifests currently has hardcoded, outdated values for its LicenseUrl and CopyrightUrl fields. This is because the winget-create tool that we use to automatically generate and publish our manifests cannot change these fields. In light of this, instead of creating and submitting manifests with a single command, update the workflow to do the following: 1. Create the manifests. 2. Update the LicenseUrl and CopyrightUrl fields with the correct version. 3. Submit the manifests. This change also adds the workflow_dispatch trigger to the release-winget workflow for easier testing in the future. Signed-off-by: Lessley Dennington <ledennin@microsoft.com>
|
Changes since v1:
|
ldennington
force-pushed
the
auto-update-urls
branch
from
fc8721e
to
e308770
Compare
derrickstolee
approved these changes
Feb 2, 2023
Comment on lines
+33
to
+34
| $shortenedVersion = $version -replace ".{4}$" | ||
| $manifestPath = dir -Path ./manifests -Filter Microsoft.Git.locale.en-US.yaml -Recurse | %{$_.FullName} |
There was a problem hiding this comment.
This is some fun script magic. It looks sensible, but we will only be sure once we run it for real.
There was a problem hiding this comment.
Welp. I did run it for real yesterday lol. I tried to write to the test repo, but the config failed and submitted a PR to the real repo instead, which I closed immediately. You can check it out here though:
https://github.com/microsoft/winget-pkgs/pull/95353/files
There was a problem hiding this comment.
Ah, I see that it wrote https://github.com/microsoft/git/blob/vfs-2.39.10/COPYING (note .10 instead of .1).
There was a problem hiding this comment.
or, perhaps you had created a v2.39.10.vfs.0.5 tag, based on the rest of the context. Carry on.
There was a problem hiding this comment.
Yes, that was one of the experimental tags I created for testing!
derrickstolee
pushed a commit
that referenced
this pull request
Feb 27, 2023
One of our winget manifests currently has hardcoded, outdated values for its LicenseUrl and CopyrightUrl fields. This is because the winget-create tool that we use to automatically generate and publish our manifests cannot change these fields. In light of this, instead of creating and submitting manifests with a single command, update the workflow to do the following: 1. Create the manifests. 2. Update the LicenseUrl and CopyrightUrl fields with the correct version. 3. Submit the manifests. This change also adds the workflow_dispatch trigger to the release-winget workflow for easier testing in the future.
derrickstolee
pushed a commit
that referenced
this pull request
Mar 2, 2023
One of our winget manifests currently has hardcoded, outdated values for its LicenseUrl and CopyrightUrl fields. This is because the winget-create tool that we use to automatically generate and publish our manifests cannot change these fields. In light of this, instead of creating and submitting manifests with a single command, update the workflow to do the following: 1. Create the manifests. 2. Update the LicenseUrl and CopyrightUrl fields with the correct version. 3. Submit the manifests. This change also adds the workflow_dispatch trigger to the release-winget workflow for easier testing in the future.
derrickstolee
pushed a commit
that referenced
this pull request
Mar 8, 2023
One of our winget manifests currently has hardcoded, outdated values for its LicenseUrl and CopyrightUrl fields. This is because the winget-create tool that we use to automatically generate and publish our manifests cannot change these fields. In light of this, instead of creating and submitting manifests with a single command, update the workflow to do the following: 1. Create the manifests. 2. Update the LicenseUrl and CopyrightUrl fields with the correct version. 3. Submit the manifests. This change also adds the workflow_dispatch trigger to the release-winget workflow for easier testing in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our winget manifests currently has hardcoded, outdated values for its LicenseUrl and CopyrightUrl fields. This is because the winget-create tool that we use to automatically generate and publish our manifests cannot change these fields.
In light of this, instead of creating and submitting manifests with a single command, update the workflow to do the following:
This change also adds the workflow_dispatch trigger to the release-winget workflow for easier testing in the future.