Upgrade deprecated GitHub Actions in build-git-installers
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade 'actions/github-script' from v3 to v6 to silence the Node.js 12
deprecation warning. Note that this also includes an update to how the
'github' object is accessed in the script ('github' -> 'github.rest')
due to a breaking change introduced in v5 [1].
[1] https://github.com/actions/github-script#breaking-changes-in-v5
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Upgrade the 'actions/upload-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Upgrade the 'actions/upload-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Upgrade the 'actions/upload-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The `ubuntu-18.04` runners are deprecated for a while now [1], and will go away this year's April Fools Day (sic!). Let's switch to the next-oldest LTS version of Ubuntu, allowing the broadest range of Ubuntu users to consume the generated `.deb` package. [1] actions/runner-images#6002 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I could not test 258464d because that would release a new |
Upgrade the 'actions/download-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Upgrade the 'actions/download-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Upgrade the 'actions/download-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Upgrade the 'actions/download-artifact' Action to v3 to stop using Node.js 12 (deprecated). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Oh, I forgot the |
|
Hooray, https://github.com/microsoft/git/actions/runs/4447499276 passed without warnings! And on that note, I'll mark this as ready for review. |
derrickstolee
approved these changes
Mar 17, 2023
dscho
deleted the
upgrade-deprecated-github-actions-in-build-git-installers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion to #566.
I pushed a tag to trigger a build that demonstrates that all the deprecation warnings are gone (for now).
EDIT: pointed the link to the build that addresses the
download-artifactwarnings.