Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-git-installers: migrate macOS and Linux off ESRP #614

Merged
merged 4 commits into from
Oct 30, 2023
Merged

build-git-installers: migrate macOS and Linux off ESRP #614

merged 4 commits into from
Oct 30, 2023

Conversation

ldennington
Copy link
Collaborator

This PR migrates microsoft/git's signing workflows off the ESRP service. This means:

  1. Updating the Linux components to sign with a GPG key.
  2. Updating macOS components to sign/notarize using Application and Installer certificates (see this series for more details).

An example run of release workflow with these changes can be found at [1].

1: https://github.com/microsoft/git/actions/runs/6635788798

@ldennington
build-git-installers: update macOS signing
ccd0b10 
Update macOS component of build-git-installers workflow to use GitHub
certificates for signing and notarization instead of ESRP.
@ldennington
build-git-installers: update Linux to use GPG signing
3e85819 
Update the Linux component of the build-git-installers workflow to use GPG
signing instead of ESRP.
@ldennington
release: remove esrp-related scripts
2914d7b 
Remove scripts that were previously used to support ESRP signing.
@ldennington ldennington changed the title Signing updates build-git-installers: migrate macOS and Linux off ESRP Oct 27, 2023
@ldennington
build-git-installers: publish gpg public key
7a89262 
Update build-git-installers workflow to publish `microsoft/git`'s GPG public
key as part of each release. Add explanation for how to use this key to verify
the Debian package's signature to the README.
@ldennington ldennington marked this pull request as ready for review October 27, 2023 22:46
dscho
dscho approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nice simplification (with the exception of the now long-winded Ubuntu instructions; I tried and failed to find a shorter version)!

@ldennington ldennington merged commit b7dec5a into microsoft:vfs-2.42.0 Oct 30, 2023
44 checks passed
@ldennington
Copy link
Collaborator Author

What a nice simplification (with the exception of the now long-winded Ubuntu instructions; I tried and failed to find a shorter version)!

These are also the same as the steps that were required when we used ESRP - I just had not written them down 😬.

@ldennington ldennington temporarily deployed to release October 30, 2023 21:48 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 30, 2023 21:48 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 30, 2023 21:48 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 30, 2023 21:48 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 02:43 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 02:43 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 02:43 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 02:43 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 03:34 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 03:34 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 03:34 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 03:34 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:31 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:31 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:31 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:31 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:49 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:49 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:49 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 16:49 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:10 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:10 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:10 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:10 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:10 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:34 — with GitHub Actions Inactive
@ldennington ldennington temporarily deployed to release October 31, 2023 17:34 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

@vdye vdye Awaiting requested review from vdye

@mjcheetham mjcheetham Awaiting requested review from mjcheetham

@jeffhostetler jeffhostetler Awaiting requested review from jeffhostetler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldennington @dscho