Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gvfs: block unsupported commands when running in a GVFS repo #91

Merged
merged 1 commit into from
Dec 13, 2018
Merged

gvfs: block unsupported commands when running in a GVFS repo #91

merged 1 commit into from
Dec 13, 2018

Conversation

benpeart
Copy link

The following commands and options are not currently supported when working
in a GVFS repo. Add code to detect and block these commands from executing.

  1. fsck
  2. gc
  3. prune
  4. repack
  5. submodule
  6. update-index --split-index
  7. update-index --index-version (other than 4)
  8. update-index --[no-]skip-worktree
  9. worktree

Signed-off-by: Ben Peart benpeart@microsoft.com

@benpeart
gvfs: block unsupported commands when running in a GVFS repo
319b60d 
The following commands and options are not currently supported when working
in a GVFS repo.  Add code to detect and block these commands from executing.

1) fsck
2) gc
4) prune
5) repack
6) submodule
8) update-index --split-index
9) update-index --index-version (other than 4)
10) update-index --[no-]skip-worktree
11) worktree

Signed-off-by: Ben Peart <benpeart@microsoft.com>
derrickstolee
derrickstolee requested changes Dec 12, 2018
View reviewed changes
Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My "request changes" is just a wait for #90, the v2.20 update in VFS, and a functional test build in VFS. I triggered the functional tests in this VFS for Git PR.

t/t0402-block-command-on-gvfs.sh
not_with_gvfs update-index --split-index
not_with_gvfs worktree list

test_expect_success 'test gc --auto succeeds when disabled via config' '
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this test! Let's also get VFS functional tests before we merge. We will also want to retest the CI builds after #90 merges.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VFS functional tests are available in this PR:
microsoft/VFSForGit#597

@derrickstolee
Copy link
Collaborator

I'm about to close and reopen to trigger the PR build again.

@derrickstolee derrickstolee reopened this Dec 12, 2018
derrickstolee
derrickstolee approved these changes Dec 13, 2018
View reviewed changes
Copy link
Collaborator

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are unblocked for merging.

@benpeart benpeart merged commit ee377e0 into microsoft:vfs-2.20.0 Dec 13, 2018
@derrickstolee derrickstolee mentioned this pull request Dec 13, 2018
Merged
derrickstolee pushed a commit that referenced this pull request Dec 17, 2018
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
45523ec 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request Feb 27, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
d8a23b0 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request Mar 29, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
aab0bcb 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request May 25, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
2f54b0c 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request May 25, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
0995e1e 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request Jun 3, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
97f531d 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request Jun 8, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
98b045d 
gvfs: block unsupported commands when running in a GVFS repo
dscho pushed a commit that referenced this pull request Aug 17, 2019
@benpeart @dscho
Merge pull request #91 from benpeart/block-commands
00628cc 
gvfs: block unsupported commands when running in a GVFS repo
derrickstolee pushed a commit that referenced this pull request Oct 23, 2019
@benpeart @derrickstolee
Merge pull request #91 from benpeart/block-commands
f0d6fbb 
gvfs: block unsupported commands when running in a GVFS repo
derrickstolee pushed a commit that referenced this pull request Nov 4, 2019
@benpeart @derrickstolee
Merge pull request #91 from benpeart/block-commands
8a5f54d 
gvfs: block unsupported commands when running in a GVFS repo
vdye pushed a commit that referenced this pull request Jun 1, 2023
@dscho @vdye
Merge advanced VFS-specific features
b80422f 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jul 7, 2023
@dscho
Merge advanced VFS-specific features
acd2c48 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit that referenced this pull request Jul 19, 2023
@dscho @vdye
Merge advanced VFS-specific features
3d3f114 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 8, 2023
@dscho
Merge advanced VFS-specific features
1adbe3d 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 8, 2023
@dscho
Merge advanced VFS-specific features
a167e0c 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Aug 11, 2023
@dscho
Merge advanced VFS-specific features
e18879a 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
jeffhostetler pushed a commit that referenced this pull request Aug 23, 2023
@dscho
Merge advanced VFS-specific features
ab37eac 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 3, 2023
@dscho
Merge advanced VFS-specific features
e9e4539 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 3, 2023
@dscho
Merge advanced VFS-specific features
2d2f30c 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 3, 2023
@dscho
Merge advanced VFS-specific features
91e1a24 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 8, 2023
@dscho
Merge advanced VFS-specific features
6938b9d 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 14, 2023
@dscho
Merge advanced VFS-specific features
2476bac 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Nov 20, 2023
@dscho
Merge advanced VFS-specific features
2a8ec98 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
vdye pushed a commit that referenced this pull request Feb 27, 2024
@dscho @vdye
Merge advanced VFS-specific features
f3c1b28 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Apr 23, 2024
@dscho
Merge advanced VFS-specific features
9e2a18a 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Apr 23, 2024
@dscho
Merge advanced VFS-specific features
75bba10 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Apr 24, 2024
@dscho
Merge advanced VFS-specific features
f921aa7 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Apr 29, 2024
@dscho
Merge advanced VFS-specific features
a002091 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request May 14, 2024
@dscho
Merge advanced VFS-specific features
b30af8e 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request May 14, 2024
@dscho
Merge advanced VFS-specific features
2d2ba50 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jun 3, 2024
@dscho
Merge advanced VFS-specific features
9464c4f 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jul 17, 2024
@dscho
Merge advanced VFS-specific features
4833703 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jul 17, 2024
@dscho
Merge advanced VFS-specific features
0220877 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jul 18, 2024
@dscho
Merge advanced VFS-specific features
3cb2ca6 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Jul 23, 2024
@dscho @mjcheetham
Merge advanced VFS-specific features
654b886 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Jul 25, 2024
@dscho
Merge advanced VFS-specific features
2d7b0df 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
mjcheetham pushed a commit that referenced this pull request Jul 29, 2024
@dscho @mjcheetham
Merge advanced VFS-specific features
618b032 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Sep 18, 2024
@dscho
Merge advanced VFS-specific features
958cceb 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Sep 24, 2024
@dscho
Merge advanced VFS-specific features
1d52da2 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
dscho added a commit that referenced this pull request Oct 8, 2024
@dscho
Merge advanced VFS-specific features
e222b1f 
Most of these were done in private before microsoft/git. However,
the following pull requests modified the core feature:

	#85
	#89
	#91
	#98
	#243
	#263

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benpeart @derrickstolee