New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac builds #418

Merged

apoorvdeshmukh merged 2 commits into main from apoorvdeshmukh/fixMacBuilds

Jul 9, 2023

Contributor

apoorvdeshmukh commented Jul 8, 2023

Mac builds failed with following error

# github.com/microsoft/go-sqlcmd/cmd/modern/root/open
root/open/ads_darwin.go:31:14: undefined: localizer
##[error]The Go task failed with an error: Error: The process '/Users/runner/hostedtoolcache/go/1.18.0/x64/bin/go' failed with exit code 2

VS Code did not throw errors/warning as it warned that this file is within mdule "." which is not included in workspace.


          Fix mac builds

7fe6860

apoorvdeshmukh requested a review from shueybubbles

July 8, 2023 03:35

shueybubbles approved these changes

View reviewed changes

Collaborator

shueybubbles left a comment


          Merge branch 'main' into apoorvdeshmukh/fixMacBuilds

6e8190b

apoorvdeshmukh merged commit ad518e3 into main

apoorvdeshmukh deleted the apoorvdeshmukh/fixMacBuilds branch

July 9, 2023 04:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet