Bug: incorrectly calculating length of security descriptor in SddlToSecurityDescriptor #298
Comments
dblohm7
added a commit
to dblohm7/go-winio
that referenced
this issue
Aug 9, 2023
…yDescriptor
unsafe.Sizeof(windows.SECURITY_DESCRIPTOR{}) is the minimum length of the SD,
not the actual length. Use the actual length for computing the length of the
slice.
This path also removes getSecurityDescriptorLength, which is no longer used.
Fixes microsoft#298
Signed-off-by: Aaron Klotz <aaron@tailscale.com>
dblohm7
added a commit
to dblohm7/go-winio
that referenced
this issue
Aug 9, 2023
…yDescriptor
unsafe.Sizeof(windows.SECURITY_DESCRIPTOR{}) is the minimum length of the SD,
not the actual length. Use the actual length for computing the length of the
slice.
This path also removes getSecurityDescriptorLength, which is no longer used.
Fixes microsoft#298
Signed-off-by: Aaron Klotz <aaron@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The landing of this PR broke
SddlToSecurityDescriptor.This line should not be using
unsafe.Sizeof(windows.SECURITY_DESCRIPTOR{})to determine the length; it should usesd.Length().The text was updated successfully, but these errors were encountered: